Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

Revert Alaska AnA Timing in model.py to Match PR 172 - #247

Merged
mxkpp merged 1 commit into
developmentfrom
maxkipp-revert-model-py-ak-ana-timing
Sep 25, 2026
Merged

mxkpp merged 1 commit into
developmentfrom
maxkipp-revert-model-py-ak-ana-timing

Conversation

@mxkpp

@mxkpp mxkpp commented Sep 25, 2026

Copy link
Copy Markdown

This reverts a block of Alaska-specific AnA timing in model.py to match PR #172.

Timeline:

  1. PR Klarkin alaska coldstart v2 #172 deactivated this Alaska-specific behavior: https://github.com/NGWPC/ngen-forcing/pull/172/changes#diff-1b679c51fe8034429f64ecbc71a5f4f46c19c0cd98115d97692a6d0971420946R223-R252

  2. The Alaska-specific behavior was reactivated with PR Refactor: bmi_model.py, config.py, model.py #191 (into a refactoring branch), which then later landed in development via PR Various Refactors (suppPrecipMod.py, parallel.py, bmi_model.py, config.py, model.py, layeringMod.py, timeInterpMod.py) #238: https://github.com/NGWPC/ngen-forcing/blame/396ef48467ef80e8d52c28628a14ee890e703f2b/NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/model.py#L166-L178

  3. 9/23/26: Test team reports a time handling bug for Alaska Coldstart. Potentially caused by the reactivation in PR Various Refactors (suppPrecipMod.py, parallel.py, bmi_model.py, config.py, model.py, layeringMod.py, timeInterpMod.py) #238.

  4. 9/25/26: This PR opened to update that block, to re-deactivate it, to match PR Klarkin alaska coldstart v2 #172.

Additions

Removals

Changes

  • See above

Testing

  1. Test team will test

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@mxkpp
mxkpp force-pushed the maxkipp-revert-model-py-ak-ana-timing branch from 453f4ff to 15ff7d4 Compare September 25, 2026 16:51
@mxkpp

mxkpp commented Sep 25, 2026

Copy link
Copy Markdown
Author

Rebased after merging #246

@mxkpp

mxkpp commented Sep 25, 2026

Copy link
Copy Markdown
Author

This was tested on ngenCERF and the symptom (Alaska Coldstart downloading the wrong file) was found to have been resolved.

@mxkpp
mxkpp merged commit 864c09b into development Sep 25, 2026
7 checks passed
@mxkpp
mxkpp deleted the maxkipp-revert-model-py-ak-ana-timing branch September 25, 2026 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant