This repository was archived by the owner on Oct 6, 2026. It is now read-only.
Repository navigation
Revert Alaska AnA Timing in model.py to Match PR 172 - #247
Merged
Merged
Conversation
mxkpp
force-pushed
the
maxkipp-revert-model-py-ak-ana-timing
branch
from
September 25, 2026 16:51
453f4ff to
15ff7d4
Compare
Author
|
Rebased after merging #246 |
Author
|
This was tested on ngenCERF and the symptom (Alaska Coldstart downloading the wrong file) was found to have been resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts a block of Alaska-specific AnA timing in
model.pyto match PR #172.Timeline:
PR Klarkin alaska coldstart v2 #172 deactivated this Alaska-specific behavior: https://github.com/NGWPC/ngen-forcing/pull/172/changes#diff-1b679c51fe8034429f64ecbc71a5f4f46c19c0cd98115d97692a6d0971420946R223-R252
The Alaska-specific behavior was reactivated with PR Refactor: bmi_model.py, config.py, model.py #191 (into a refactoring branch), which then later landed in
developmentvia PR Various Refactors (suppPrecipMod.py,parallel.py,bmi_model.py,config.py,model.py,layeringMod.py,timeInterpMod.py) #238: https://github.com/NGWPC/ngen-forcing/blame/396ef48467ef80e8d52c28628a14ee890e703f2b/NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/model.py#L166-L1789/23/26: Test team reports a time handling bug for Alaska Coldstart. Potentially caused by the reactivation in PR Various Refactors (
suppPrecipMod.py,parallel.py,bmi_model.py,config.py,model.py,layeringMod.py,timeInterpMod.py) #238.9/25/26: This PR opened to update that block, to re-deactivate it, to match PR Klarkin alaska coldstart v2 #172.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support