Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

feat: update schema for run of river dams in lakes table - #110

Merged
quercoak merged 5 commits into
mainfrom
fear/res-da-schema
Sep 24, 2026
Merged

quercoak merged 5 commits into
mainfrom
fear/res-da-schema

Conversation

@quercoak

@quercoak quercoak commented Sep 23, 2026 •

Copy link
Copy Markdown

Updates the lakes schema to include source, run of river, dam crest, and spillway width for t-route
Adds guard for running subset-nhf locally from parquet

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@quercoak
quercoak marked this pull request as ready for review September 24, 2026 19:45
@quercoak
quercoak merged commit 9b7dec6 into main Sep 24, 2026
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant