[FE][SYNC-232] SYNC-V2 New Navbar and UI components - #68
Conversation
yccodr
left a comment
yccodr
left a comment
There was a problem hiding this comment.
The text in the dropdown should be aligned with the title.
| const req = require.context('@/assets/icons', true, /\.svg$/) | ||
| requireAll(req) | ||
| Vue.component('icon', SvgIcon) | ||
| Vue.component('SyncButton', SyncButton) |
There was a problem hiding this comment.
Why SyncButton should be globally registered? Can't we import it when we need it?
There was a problem hiding this comment.
I'd prefer making it more like BootstrapVue, where components are globally visible
There was a problem hiding this comment.
That's fair enough, but I think importing the component when we need it would be better. It would shrink down the chunk size after the build.
| await loginFunc() | ||
| this.$router.back() | ||
| const redirect = this.getRedirectPath | ||
| if (redirect) { this.$router.push({ path: redirect.redirect }) } else { this.$router.back() } |
There was a problem hiding this comment.
If the router starts at '/login', then there's no entry in the history stack. this.$router.back() won't work.
Maybe add more checks to prevent this behavior? (e.g. by checking router.START_LOCATION)
Changes: - rm title - fix link to article image - fix css import
…frontend into feature/SYNC-232
2 participants
Description:
SyncButtonChanges:
<SyncButton>with similar interfaces as bootstrap-vue buttonssize,pill,variant(primary, tertiary),squaredTODO:
Test Scope:
Navbar
開始編輯should redirect to edit page after loginSearch bar
Profile Page
Screenshots (optional)