Addressing issue #876 to add RRF scores - #886
Open
hyi wants to merge 8 commits into
Open
Conversation
MarkDWilliams
approved these changes
Sep 10, 2026
Collaborator
|
Looks good to me on review, but yes, I'll test locally before merging it. Thanks for putting this together @hyi |
Author
|
@MarkDWilliams Thanks for the prompt review. I realized I needed to handle tied RRF scores for ranking, so I just made a new commit to handle tied RRF score ranking, so that if two query results have the same RRF ranker combination score, their ranks will be set as the same. Take a quick look at that commit and let me know if you see any issues or have questions. I'll address any potential issues from your local testing if any. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue #876 to add RRF scores.
@MarkDWilliams It'd be great if you could test this out since I don't know the ARS workflow enough to test it locally. The following three new environment variables are introduced as shown below:
Let me know if you have any questions once you get a chance to do code review. Thanks