Repository navigation
fix(web): link-coloured chat links, repository lane row, faded thread titles - #2279
Merged
Merged
Conversation
Chat links used the amber primary colour, a trailing external-link icon, and rewrote bare URLs to owner/repo#n. DESIGN.md reserves amber for primary actions and gives links the link colour. Links now show the site mark and the URL as written.
The repository had its own headed section in the activity block. It now renders as a lane row between Commit and the pull request, styled like its neighbours.
titleFrom cut the first line at 50 characters and appended '...', so headers showed a literal ellipsis instead of the fade-out truncation. Titles now keep up to 200 characters, cut at a word boundary, and clients fade the overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three display fixes for the chat and the thread view.
Chat links. Links in chat prose used the amber primary colour, shortened bare GitHub URLs to
owner/repo#n, and ended with an external-link icon. They now use the blue link colour from DESIGN.md and show the URL exactly as written. The site favicon still comes before the link, so GitHub links lead with the GitHub mark.Repository in the overview. The repository had its own "Repository" section with an amber heading and an external-link icon. It is now one lane row with the GitHub mark and
owner/repo. It sits below the Commit row and above the pull request rows. Clicking it still opens the remote.Thread titles. When a thread had no explicit title, the server took the first line of the message and cut it at 60 characters with a literal
.... The header then showed that ellipsis instead of fading the text. The server now keeps up to 200 characters, cuts at a word boundary, and adds no ellipsis. The header already fades text that overflows.Verified with focused Vitest runs (web: 4 files, 56 tests; server:
thread-title.test.ts, 4 tests),tsc --noEmitforapps/webandapps/server, andbun run lint. I also checked the web app against the fixture repository, with a GitHub remote added.Why
Links should look like links. Amber is reserved for primary actions, so amber links looked like buttons. A one-row repository entry also fits the rest of the overview lane. The title ellipsis broke the rule that text fades at the right edge and never ends in an ellipsis.
UI Changes
Chat link. Target, then after.
Overview repository row. Before, then after.
Thread header. Before, then after.
Review Notes
...still show the ellipsis. This PR does not include a migration.OVERVIEW_ENTRIES(commit 80, repository 95, pull request 110), andoverview-registry.test.tsxcovers it.owner/repo#nshortening. Authored link text was never rewritten and is still not rewritten.Need help on this PR? Tag
@codesmith-botwith what you need.