Repository navigation
fix(web): name Mcode thread tools and approvals in plain words - #2274
Merged
Merged
Conversation
Rows for workspace, worktree, target, and thread tools now use plain labels
in finished, failed, running, and grouped states. A call with no arguments
shows no detail instead of {} or its raw tool name. Tool approval receipts
name the tool the way its row does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mcode thread tools used to show their raw names in the timeline, such as
thread_target_list. A call with no arguments also showed{}beside the name. A decided tool approval read "Allowed once mcp__mcode__thread_target_list".Now each thread tool row has a plain label, such as "Listed targets". This holds for running, finished, failed, and grouped rows. A row whose input is empty shows no detail. A tool approval receipt names the tool the same way its row does, both live and after reload.
I verified it with a real supervised Claude turn in Electron that called
thread_target_list. The captures below show the same thread on the old and new renderer. Targeted web tests pass (105 files, 1099 tests), and typecheck and oxlint are clean. The new tests failed on the old code (54 failures).Closes #2270
Why
People who direct agents read these rows to follow what the agent did. Raw MCP names and a stray
{}make that harder to read, and the receipt disagreed with the row above it.UI Changes
Before. The row shows the raw name and
{}, the group reads "1 thread_target_list call", and the receipt shows the prefixed name.After. The row reads "Listed targets", the group reads "Listed targets 1 time", and the receipt reads "Allowed once Listed targets".
The running row also reads "Listed targets" while it waits for approval.
Review Notes
thread_create_batchgets no label. Only the legacy external transport exposes it.Need help on this PR? Tag
@codesmith-botwith what you need.