Repository navigation
Refresh view after position or size adjustments to prevent stale clipping - #325
Merged
Merged
Conversation
Ensure view is updated after potential clipping changes.
nox7
changed the title
Member
|
My bad, I got too far with optimizing performance for unchanged geometry and also did not covered that with enough tests. I'll add few tests, that failed without your fix. This will be done outside this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I understand 3.5.2 is not out yet, but I am testing latest commits in OpenMW and found that recent commits to cache coordinates have caused stale clipping. See the image and the video below:
2026-10-05.15-35-41.mp4
With the fix from this PR:
Alignment should refresh clipping