Repository navigation
Stabilize the Windows canceled Meeting stop test - #84
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real SQLite-lock stop test could fail on Windows CI when its two-second
wait_forissued another cancellation and converted the expectedCancelledErrorintoTimeoutError. The independent qualification suite and the focused local test passed at the same source revision.Observe settlement through
asyncio.waitwith a bounded ten-second guard, then assert the original cancellation separately. The test still requires completed finalization handoff, released audio ownership, one recorder stop, and empty capture/task ownership. Production code and release authorization rules are unchanged.Validation: all five SQLite-lock settlement cases pass locally; Ruff lint/format and
git diff --checkpass. This follows PR #83 so its installer can qualify without accepting a previously failed attempt as release evidence.