fix: correct scale_id lookup in HTTP endpoints - #5
Merged
Conversation
The /weight, /tare, /zero handlers referenced the closure var instance_info['id'] - wrong key (it is 'scale_id') and the wrong object (app.state.instance_info), so every call raised KeyError. /info also returned the whole dict as scale_id. All now read app.state.instance_info['scale_id'].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/weight,/tare,/zerohandlers referencedinstance_info['id']- the wrong key (the dict usesscale_id, per the docstring and/status) and the wrong object (the closure var, notapp.state.instance_info), so every call raisedKeyError./infoseparately returned the entireinstance_infodict asscale_id. All four now useapp.state.instance_info['scale_id']. Found by the 2026-06-21 fleet sweep. 14 tests pass; lint clean.