fix(tests): update umbrella hw/preflight tests for msw-core 0.29 - #25
Merged
Conversation
The umbrella's copies of these integration tests drifted behind msw-core: the BpodFactory call now carries workspace_path/session_name (the pybpod-workspace fix), and preflight emits a bulleted 'Pre-flight check failed' message using the lowercase device name. Update the assertions to match; no behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The umbrella's copies of
test_hardware_manager.py/test_preflight_and_pipeline.pydrifted behind msw-core (installed from PyPI in CI), so umbrella CI has been red for any PR:BpodFactoryis now called withworkspace_path=None, session_name=None(the pybpod-workspace fix) — updated theassert_called_once_with.Pre-flight check failed: …message with the lowercase device name — updated thematch/inassertions.Assertion-only; no behaviour change. Unblocks the config-docs PR (#24) and greens umbrella CI. (These are the stale extracted tests the roadmap tracks for relocation into msw-core.)