refactor(cli): de-dup setup/subject config commands - #78
Merged
Conversation
- Extract `_write_yaml()` for the repeated yaml.dump options and
`_rename_config()` for the near-identical setup/subject rename flows in
run_setup/run_subject; all user-facing messages are preserved verbatim.
- Replace the `__import__("sys")`/`__import__("datetime")` calls in
run_subject with the existing module `sys` import and a proper
`import datetime`.
- Add characterization tests for the setup/subject create + rename
commands, which previously had no coverage.
Patch bump (refactor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour-preserving cleanup of the
msw setup/msw subjectconfig-command handlers incli/execute.py.What
_write_yaml(path, data)— collapses the four identicalyaml.dump(..., default_flow_style=False, allow_unicode=True, sort_keys=False)blocks inrun_setup/run_subjectinto one helper._rename_config(dir, old, new, *, force, label)— collapses the near-identical setup/subjectrenameflows into one helper, parameterised by a capitalisedlabelso every user-facing message (Renamed setup …,… not found at …,… already exists … Use --force) stays byte-for-byte identical. The setup-only empty-name guard remains inline inrun_setup.__import__("sys")/__import__("datetime")hacks inrun_subject—syswas already imported at module top; added a properimport datetime.Tests
Adds
tests/test_cli_config_commands.py— the setup/subject create + rename commands had no coverage. The tests pin the on-disk YAML shape (name, seeded bpod device,registeredtimestamp) and the rename-updates-name / refuse-existing-without-force behaviour that the shared helpers now depend on.No behaviour change; full msw-core suite green.