refactor(boundary): drop non-bpod device ports from the task boundary - #76
Merged
Merged
Conversation
Cycle D Step 4 (partial): serial_port_stage/scale/pulsepal no longer cross the task boundary - every task now reads those devices from the injected collection. Removed from RunContext.to_task_kwargs and stripped from args_dict at the execute.run_task boundary; characterization tests updated. serial_port_bpod stays: TaskProcess takes it as a constructor param for the no-collection bpod-open fallback (its removal rides the TaskProcess lifecycle refactor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cycle D Step 4 (partial):
serial_port_stage/serial_port_scale/serial_port_pulsepalno longer cross the task boundary. Every task now reads those devices from the injectedDeviceCollection(fixedsubjects/stage, optotagging & exp_trn_spindle/pulsepal), so the ports are pure orchestrator-internal resolution detail (ctx.portsdrives device construction).RunContext.to_task_kwargs().args_dictat theexecute.run_taskboundary (they also arrive via the CLI dict).test_run_task_boundary,test_run_context,test_evaluate_args_characterization).What stays
serial_port_bpodremains at the boundary:TaskProcess.__init__takes it as a constructor param for the no-collection bpod-open fallback (and re-injects it), and optotagging's_scope_bpod_to_sessionstill uses it for the real-HW workspace re-open. Its removal rides the TaskProcess God-constructor / bpod-lifecycle refactor (get the port from the bpod descriptor) — tracked separately.Verification
--simulatesmoke: still runs, stage comes from the collection (SimStage), noserial_port_stageat the boundary.