test(spine): characterize evaluate_args resolved-dict shape - #69
Merged
Conversation
Snapshot the key set evaluate_args produces and the RunContext it derives, in --simulate --debug mode with the five I/O side effects mocked. The Phase-0 net for the planned evaluate to RunContext migration: any change to the resolved shape updates the snapshot deliberately. Also pins that to_task_kwargs's only additions over the resolved dict are the serial_port_* keys. Test-only.
Snapshot the key set evaluate_args produces and the RunContext it derives, in --simulate --debug mode with the five I/O side effects mocked. The Phase-0 net for the planned evaluate to RunContext migration. Skips when no msw.tasks entry points are registered (msw-core CI is isolated), so it runs in the full workspace locally where the migration work happens. Test-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshots the exact key set
evaluate_argsproduces and theRunContextit derives, driven in--simulate --debugmode (_test_subject, no on-disk config) with the five I/O side effects mocked (logging, preflight, host session, host name/ip) so the pipeline is pure and deterministic.This is the Phase-0 net for the planned
evaluate→RunContextmigration: any change to the resolved-dict shape must update the snapshot deliberately. Together with the run_task boundary test (#66) and the RunContext/to_task_kwargs tests, the chain evaluate → RunContext → boundary is now pinned.Also documents a boundary subtlety it surfaced:
to_task_kwargs's only additions over the resolved dict are theserial_port_*keys — evaluate omits them for a no-setup run (TaskProcess defaults them toNone),to_task_kwargsemits""; all falsy, so equivalent at the boundary. Test-only.