refactor(spine): to_task_kwargs boundary key is 'task' not 'task_name' - #68
Merged
Merged
Conversation
to_task_kwargs() is the frozen boundary projection RunContext will hand tasks, but it emitted 'task_name' while the actual contract key - the TaskProcess constructor param and what every task reads - is 'task'. Switching the boundary onto to_task_kwargs() would have handed tasks the wrong key. Fix the projection and pin it with a test that its keys are a faithful subset of the resolved args_dict. No runtime effect yet (to_task_kwargs is not called at the boundary until a later phase).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_task_kwargs()is the frozen boundary projectionRunContextwill hand tasks (the linchpin of retiring the dict). But it emitted"task_name"while the actual contract key — theTaskProcessconstructor param and what every task reads — is"task". Switching the boundary ontoto_task_kwargs()(a later phase) would have silently handed tasks the wrong key; the new boundary characterization test (#66) would have caught it."task".to_task_kwargs()keys must be a faithful subset of the resolvedargs_dict(never invent a key tasks don't read).No runtime effect yet —
to_task_kwargs()is not called at the boundary until a later phase.