Make output table headers sticky - #30
Open
Nightfirecat wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change would make some of the output table headers have sticky position--that is, remain visible at the top of the browser window when scrolling past the top of the table--which is, in my opinion, very helpful for some tables, particularly the enchants table.
Note, this PR does not impact any calendar tables (such as those for garbage can, mines, and night events) as those tables have the class "calendar" rather than "output". Perhaps they would also benefit from this treatment? They're usually not so tall, so I thought I would leave that up to you whether that would be wanted.