Skip to content

fix: add URL validation in templateLoader.js (CWE-918) #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anupamme wants to merge 4 commits into from
Closed

fix: add URL validation in templateLoader.js (CWE-918) #30

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d379f6d
Merge pull request #27 from Mountea-Framework/dev
pavlicekdominik Apr 19, 2026
822be97
Merge pull request #28 from Mountea-Framework/dev
pavlicekdominik Apr 24, 2026
a300ccb
Merge pull request #29 from Mountea-Framework/dev
pavlicekdominik Oct 6, 2026
25b8ca3
fix: multi_agent.cwe-918 security vulnerability
anupamme Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/lib/onboarding/templateLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ function toTemplateFile(blob, source) {

const ALLOWED_TEMPLATE_HOSTS = new Set(['github.com', 'raw.githubusercontent.com']);

function assertAllowedTemplateUrl(value, sourceLabel) {
function assertAllowedTemplateUrl(value, sourceLabel, { allowRelative = false } = {}) {
let url;
try {
url = new URL(String(value), globalThis.location?.href);
url = allowRelative ? new URL(String(value), globalThis.location?.href) : new URL(String(value));
} catch (_error) {
url = null;
}
const sameOrigin = url && globalThis.location && url.origin === globalThis.location.origin;
const sameOrigin = allowRelative && url && globalThis.location && url.origin === globalThis.location.origin;
const allowedRemote = url && url.protocol === 'https:' && ALLOWED_TEMPLATE_HOSTS.has(url.hostname);
if (!sameOrigin && !allowedRemote) {
throw new OnboardingTemplateError(
Expand All @@ -45,13 +45,13 @@ function assertAllowedTemplateUrl(value, sourceLabel) {
return url.href;
}

async function fetchBlob(url, sourceLabel) {
const safeUrl = assertAllowedTemplateUrl(url, sourceLabel);
async function fetchBlob(url, sourceLabel, { allowRelative = false } = {}) {
const safeUrl = assertAllowedTemplateUrl(url, sourceLabel, { allowRelative });
const controller = new AbortController();
const timeout = setTimeout(() => controller.abort(), 10000);
try {
const response = await fetch(safeUrl, { cache: 'no-store', signal: controller.signal });
if (response.url) assertAllowedTemplateUrl(response.url, sourceLabel);
if (response.url) assertAllowedTemplateUrl(response.url, sourceLabel, { allowRelative });
if (!response.ok) throw new Error(`${sourceLabel} fetch failed with HTTP ${response.status}`);
const limit = 32 * 1024 * 1024;
if (Number(response.headers.get('content-length')) > limit) { controller.abort(); throw new Error('Onboarding template size is invalid'); }
Expand Down Expand Up @@ -152,7 +152,7 @@ export async function resolveOnboardingExampleTemplateFile() {
} catch (remoteError) {
const bundledUrl = bundledTemplateUrl;
try {
const blob = await fetchBlob(bundledUrl, 'Bundled onboarding template');
const blob = await fetchBlob(bundledUrl, 'Bundled onboarding template', { allowRelative: true });
return {
file: toTemplateFile(blob, 'bundled'),
source: 'onboarding-bundled',
Expand Down