refactor: generalize hybrid attention checkpoint management - #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the existing linear/full checkpoint flow into reusable hybrid interfaces, without including the Gemma/sliding-window implementation.
HybridAttentionReqManagerfor request-state initialization, big/small-page snapshots, restoration and model-specific MTP state updates. Conv/SSM access stays inside the linear implementation.common/state_cache_manager/: shared slot allocator and layer storage, with the linear config and buffers together inlinear_att.py.--linear_att_*options. Model-specific PD packing/restoration and payload layouts remain unchanged. Rename the PD page kind fromlinear_att_statetoatt_stateand document its boundary-state semantics; P and D must be updated together because the kind is part of the task identity.