Repository navigation
Revive HoneyBadger automation modules - #5
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ($GenerateUndoScript) { | ||
| $undoArgs = @{ UndoFromLog = $UndoLog; Quiet = $true } | ||
| $undoPath = Invoke-HBVModule -ScriptPath (Get-ModulePath 'PimpMyWindows.ps1') -Arguments $undoArgs | ||
| $summary.UndoScript = $undoPath | ||
| if ($undoPath) { | ||
| Write-CoreLog -Message "## UNDO: Script generated at $undoPath" -Color Cyan | ||
| } | ||
| } | ||
| } | ||
| elseif ($PSCmdlet.ParameterSetName -eq 'UndoOnly' -and $GenerateUndoScript) { | ||
| $undoArgs = @{ UndoFromLog = $UndoLog; Quiet = $true } | ||
| $undoPath = Invoke-HBVModule -ScriptPath (Get-ModulePath 'PimpMyWindows.ps1') -Arguments $undoArgs |
There was a problem hiding this comment.
-Quiet switch when generating undo
When HBV-Core asks PimpMyWindows to build an undo script (GenerateUndoScript path), it always adds Quiet = $true to the argument hashtable. The updated PimpMyWindows.ps1 only exposes -Quiet in the CLI/GUI parameter sets—its Undo set accepts -UndoFromLog but not -Quiet. Passing -Quiet therefore triggers a parameter-binding exception before the undo script runs, so HBV-Core.ps1 -GenerateUndoScript fails even in dry-run scenarios. Drop the Quiet switch (or update PimpMyWindows to accept it in the Undo set) so undo generation actually executes.
Useful? React with 👍 / 👎.
2 participants
Summary
Testing
Codex Task