Skip to content

Fix issue #569 remove BaseURL - #576

Open
awmirantis wants to merge 2 commits into
Mirantis:masterfrom
awmirantis:fix-issue-569-baseurl
Open

awmirantis wants to merge 2 commits into
Mirantis:masterfrom
awmirantis:fix-issue-569-baseurl

Conversation

@awmirantis

Copy link
Copy Markdown
Contributor

Fixes #
Issue #569

Proposed Changes

BaseURL is left nil so streaming.NewServer fills in the correct
scheme and host.

@awmirantis
awmirantis requested review from a team and sgajlekar-spec September 11, 2026 15:08

@chenyaooo chenyaooo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgajlekar-spec sgajlekar-spec left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants