### **PR Title: Fix: Resolve i18n configuration and update dependencies**#335
### **PR Title: Fix: Resolve i18n configuration and update dependencies**#335SHEROSE0 wants to merge 2 commits into
Conversation
|
@SHEROSE0 is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
Miracle656
left a comment
There was a problem hiding this comment.
Thanks, but this doesn't yet implement #307 and has a couple of issues:
-
#307 asks for the actual Spanish translation of the marketing site (hero/features/CTA strings) with locale routing — this PR only adds an
i18nblock tonext.config.jsand no translated content, so the issue isn't addressed. -
The
i18nkey innext.config.jsdoes nothing here —frontend/websiteis on the App Router (app/), and thenext.config.jsi18noption is a Pages-Router-only feature that the App Router ignores entirely. App Router i18n needs middleware-based locale detection +[lang]route segments (or a library likenext-intl), plus the translated message catalogs. -
Please don't remove
reactStrictMode: true— that's a regression, and it's unrelated to i18n. -
The
package-lock.jsonchanges bump unrelated deps (e.g.@supabase/supabase-jsto 2.108.2) — please drop those; dependency bumps should be their own PR (dependabot handles them).
To actually close #307: set up App-Router i18n routing and add the es translations for the hero/features/CTA. Happy to review once that's in. Thanks!
#closes #307
Description:
This PR addresses configuration errors in
next.config.jsto ensure the development server initializes correctly. It also includes an update topackage-lock.jsonto maintain project consistency.Changes:
next.config.jsto resolve duplicatei18nproperty declarations.package-lock.jsonto ensure environment stability.Testing:
npm run devstarts successfully without configuration syntax errors.#closes