feat: add Playwright browser matrix tests for SDK#326
Conversation
|
@AugistineCreates is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…on, Codecov badge
|
Note: this PR is byte-for-byte identical to #327 (same 8 files, same diff) — it's the same changeset opened twice against two different issues (#253 here, #254 on #327). A single PR can close both issues, so please consolidate into one (keep #327, which I've left detailed review feedback on, and close this duplicate). The blocking issues are the same as on #327: it's based on pre-#315 |
|
Closing as a duplicate of #327 — the two are byte-for-byte identical (same 8 files, same diff), just pointed at different issues (#253 here, #254 on #327). A single PR can close both, so please continue on #327 (where I left the detailed review: fix the invalid-JSON comma, drop the #315 revert, and have it close both #253 and #254). Nothing's lost — your work lives on in #327. Thanks! 🙏 |
This pr closes #253
This PR introduces a comprehensive Playwright testing matrix for the SDK to ensure the WebAuthn happy‑path works consistently across all major browsers (Chromium/Chrome, Firefox, and WebKit/Safari).
What’s added
Playwright configuration (
sdk/playwright.config.ts)chromium,firefox,webkit.npm run dev) before tests.Browser matrix test (
sdk/tests/browser-matrix.spec.ts)useInvisibleWallet) is available.CI workflow update (
.github/workflows/ci.yml)sdk-browser-matrix:npx playwright install --with-deps).npx playwright test --config playwright.config.ts).playwright-report).Documentation (CONTRIBUTING.md)
Why