Feat/i18n#212
Conversation
- Install react-i18next, i18next, and i18next-browser-languagedetector - Create i18n configuration with lazy-loading from /locales - Add English baseline translations for all user-facing strings - Add Spanish translations for dashboard, send, receive, and settings flows - Wrap user-facing strings in t() calls across key pages - Add LanguageSwitcher component in settings page - Auto-detect browser language on first load - Persist language selection in localStorage - Organize translations into logical namespaces: common, dashboard, send, receive, settings, errors
|
@Harbduls is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Harbduls Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Miracle656
left a comment
Miracle656
left a comment
There was a problem hiding this comment.
Nice work on i18n — the en/es locale split, LanguageSwitcher, and lib/i18n.ts are well-organized. A few things before merge:
- Conflicts — the branch is behind
mainand now conflicts (severalapp/*/page.tsxfiles have moved, pluspackage-lock.json). Please rebase on the latestmain. - Remove committed build artifacts —
frontend/wallet/tsconfig.tsbuildinfoand.vscode/settings.jsonshouldn't be in the PR (the tsbuildinfo is a generated cache). Please drop them and add tsbuildinfo to.gitignoreif it isn't already.
Once rebased and the artifacts are removed, I'll review the locale wiring and merge.
|
Friendly nudge — i18n is now CONFLICTING with If you're still up for it, please rebase on the latest |
2 participants
Closes #170