Repository navigation
fix: diagnose content review failures without blaming connectivity - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Content-review failures could stop a turn without production diagnostics while the TUI blamed the user's network. Both V1 and V2 now emit a bounded failure record in production with a local review ID, endpoint hostname, scene, duration, failure category, and available status code. Transport classification keeps only allowlisted DNS, connection, TLS, timeout, abort, or unknown categories; no raw exception, request/response body, token, attachment URL, or upstream trace header is logged.
The TUI explains that review returned no usable result and withheld unreviewed output.
/reloadretains the actual diagnostic and no longer directs every failure to keybindings. Legacy and Runtime V2 runners record the session/turn and review-stop outcome separately from the existing completed terminal. Completed still preserves approved output; a real runner failure remains authoritative. Fail-closed behavior and retry limits are unchanged, as is the legacy V1 service-degradation policy.Refs #218. No community patch was imported. Documentation impact: warning text changes only; no new commands or configuration.
Validation
/reloaddiagnostics.pnpm typecheckandgit diff --check: passed.pnpm verifyon clean HEAD5eca87671f88d22757f5199187f9d143d7a5aaf1(macOS arm64, Node 26.4.0): 14/14 gates passed, 131.0 seconds.Publication and contribution checks
release/public-source.json. Tests extend existing declared Vitest files.Maintainer handoff
Publication scope or license changes: none.
Shared-source port: pending after public review.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.