Repository navigation
fix: persist explicit BYOK image capabilities - #225
Merged
Merged
Conversation
Add provider add --support-image and preserve capability metadata through create and update inputs. Cover saved configuration and actual image transport with the packaged offline BYOK fixture. Adapted the CLI declaration and capability preservation approach from smartworldarafath/minimax-code commit 6ec8ad0. Keep explicit image-input semantics without inferring vision from generic attachments or catalog fallbacks. Co-authored-by: smartworldarafath <smartworld.bd.710@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Refs #213. Unknown custom models could not declare image support through
provider add, and the provider input normalizer discarded newly suppliedcapabilities. Add--support-imagefor every listed model and preserve/merge explicit capability metadata through create, candidate save, and update. Share the process-local model input contract so these operations expose the same fields.Existing YAML declarations (
modalities.input: [text, image]orcapabilities.support_image: true) already enable images. Their semantics stay unchanged: genericattachment: truedoes not imply image input, and this change does not infer vision from model names or the SDK catalog. The configuration guide covers new and existing providers, text-only rollback, and the text-only scope of connection tests.The Ollama model page currently lists vision support for the reported model. This independently checks the catalog claim, not live endpoint acceptance.
Community contribution
Reviewed and adapted the CLI declaration and capability-preservation approach from smartworldarafath's patch. The commit retains a
Co-authored-bytrailer. Capability inference from generic attachments, undocumented aliases, and catalog-only fallback were not imported. Validation below was run independently.Validation
db4ea90fa66b33f89fe4543e676ee0eaa1c9e2a2.provider add --helpincludes the flag. Packaged offline BYOK checks exercise both save-only and--usepaths, multiple models, failed-test atomicity, YAML reload in a new process, and actual OpenAI-compatible image request bodies. Existing modality configuration succeeds; undeclared and attachment-only models retain text-only behavior. PNG input goes through the real JPEG preprocessing path.pnpm verifyon the clean committed revision above: all 14 gates passed, macOS arm64, Node 26.4.0. This includes 3,615 capability tests, 17 CLI/ACP smoke tests, the offline BYOK fixture, and real macOS sandbox checks.git diff --checkpassed. No source files were added or removed; all modified Vitest files were already registered, so no inventory regeneration was needed.image: false; this PR does not add ACP image input.Publication and contribution checks
release/public-source.json; new tests are declared intest/vitest-suites.jsonwhere applicable.Maintainer handoff
Publication scope or license changes: none. Shared-source port: pending. Keep this PR open for review; no merge, release, or deployment is included.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.