Repository navigation
fix: preserve system prompts for SiliconFlow - #209
Merged
Merged
Conversation
hetaoBackend
approved these changes
Sep 20, 2026
hetaoBackend
previously approved these changes
Sep 20, 2026
SaladDay
dismissed
hetaoBackend’s stale review
September 20, 2026 04:29
The merge-base changed after approval.
hetaoBackend
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Preserve
systemfor thinking-enabled custom OpenAI Chat Completions connections toapi.siliconflow.cnandapi.siliconflow.com.Only the default message-role capability changes for these exact hosts. Thinking, explicit compatibility overrides, other request options, and other endpoints retain their behavior. Kimi (#206) and DashScope (#207) are inherited unchanged. Authentication, thinking-toggle behavior, and connection-test redesign are outside scope. This PR targets main after #207 was squash-merged.
Stack
main -> #209 -> #210#207 is already merged. Merge #209 first. After #209 is squash-merged, synchronize #210 with the new main and retarget it to main before merging. Changing the base alone does not reconcile squash-merged ancestry. Each PR is reviewed against its immediate base.
Evidence
developerin the accepted message roles.supportsDeveloperRole: falseforapi.siliconflow.com. It was closed without merging; the proposal is supporting context, not an upstream release claim.Validation
23aacf0.git diff --checkpassed.Publication and maintainer handoff