Skip to content

fix: preserve system prompts for SiliconFlow - #209

Merged
hetaoBackend merged 7 commits into
mainfrom
fix/siliconflow-system-role
Sep 20, 2026
Merged

hetaoBackend merged 7 commits into
mainfrom
fix/siliconflow-system-role

Conversation

@SaladDay

@SaladDay SaladDay commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

Change

Preserve system for thinking-enabled custom OpenAI Chat Completions connections to api.siliconflow.cn and api.siliconflow.com.

Only the default message-role capability changes for these exact hosts. Thinking, explicit compatibility overrides, other request options, and other endpoints retain their behavior. Kimi (#206) and DashScope (#207) are inherited unchanged. Authentication, thinking-toggle behavior, and connection-test redesign are outside scope. This PR targets main after #207 was squash-merged.

Stack

main -> #209 -> #210

#207 is already merged. Merge #209 first. After #209 is squash-merged, synchronize #210 with the new main and retarget it to main before merging. Changing the base alone does not reconcile squash-merged ancestry. Each PR is reviewed against its immediate base.

Evidence

Validation

  • Focused resolver suite: 97 tests passed, covering both official hosts, unrelated host/path matches, preserved reasoning, and explicit compatibility overrides. The newly covered endpoint failed before the matcher update.
  • Full verification: all 14 gates passed on macOS arm64 / Node 26.7.0 at 23aacf0.
  • Fresh independent blind review of the stacked changes found no actionable issues; git diff --check passed.

Publication and maintainer handoff

  • Existing licenses and notices are preserved; publication scope is unchanged.
  • No credentials, account data, user content, private review material, or internal history is included.
  • No source files were added or removed; tests extend an already registered file.
  • Documentation impact is limited to the vendored patch ledger.
  • Shared-source port: pending.

@SaladDay SaladDay changed the title fix: preserve system prompts for SiliconFlow China fix: preserve system prompts for SiliconFlow Sep 19, 2026
@SaladDay
SaladDay changed the base branch from main to fix/dashscope-system-role September 20, 2026 03:39
@SaladDay
SaladDay added this pull request to stack #229 September 20, 2026 03:42
hetaoBackend
hetaoBackend previously approved these changes Sep 20, 2026
Base automatically changed from fix/dashscope-system-role to main September 20, 2026 04:28
@SaladDay
SaladDay dismissed hetaoBackend’s stale review September 20, 2026 04:29

The merge-base changed after approval.

@hetaoBackend
hetaoBackend merged commit 0fa4888 into main Sep 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants