Skip to content

Request: collaborator access to contribute docs fix #158 (Eswar809) #174

Closed

Description

@Eswar809

Hi maintainers, I would like collaborator access for Eswar809 to submit a docs-only fix for #158. Fork ready at Eswar809/minimax-code branch fix/docs-data-dir-158. Validation pnpm verify --profile docs PASS. Thanks!

Activity

  1. hetaoBackend commented on Sep 19, 2026

    @hetaoBackend
    Collaborator

    Thanks for preparing the patch and running the documentation checks. Collaborator access requires a separate maintainer decision; this reply does not grant access or change the current contribution policy.

    For #158, the published 0.4.12 behavior and current source-build default need to be documented separately, rather than replacing every ~/.minimax-code reference with ~/.minimax. I'm following up on that distinction in a maintainer documentation task and will link its PR on #158.

  2. added
    needs-triageAwaiting maintainer assessment
    questionUsage or project-policy question
    and removed on Sep 19, 2026
  3. hetaoBackend commented on Oct 13, 2026

    @hetaoBackend
    Collaborator

    Hi @Eswar809 — thank you for the patch and for following the contribution route. Sorry for the long silence on this thread; that was our failure, not yours.

    Two things you should know:

    1. #158 has since been fixed internally — it was closed by #178 and #188, which corrected the same ~/.minimax vs ~/.minimax-code path documentation. So the specific task you prepared for is no longer open.

    2. Your fork and branch are still valid. Nothing about your preparation is wasted:

    • If you spot anything the internal fix missed or got wrong, please open a PR from your fork — no collaborator access is required to submit a fork PR, and we will review it.
    • The same applies to any other docs or code change you have prepared. Fork PRs are welcome; please describe the scope of the change in an issue first so we can confirm it is not already being worked on.

    3. On the access question: we are changing the contribution policy from invitation-only to application-based, so that external PRs can be submitted directly. Until that change lands, you do not need write access to contribute — a fork PR with a linked issue is enough, and we review it within 48 hours.

    If you would like to pick up a scoped task that is already tracked, the good first issue label is the canonical list: good first issue Good for newcomers — items there are expected to be independently completable with pnpm verify --profile docs as the verification command.

    Closing this request because the original task was completed internally. If you submitted a patch that you believe is still needed, please open a new PR from your fork and link it here — it will be reviewed.

  4. hetaoBackend commented on Oct 13, 2026

    @hetaoBackend
    Collaborator

    Closing: the docs fix this request referred to (#158) was completed internally by #178 and #188. @Eswar809's fork and branch remain valid — if anything in that fix is missing or wrong, please open a fork PR (no collaborator access required) and it will be reviewed within 48h. See my previous comment for the new contribution path.

  5. added
    contribution-requestRequest for contribution access or a scoped contribution path; requires a 48h decision
    and removed
    needs-triageAwaiting maintainer assessment
    on Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    contribution-requestRequest for contribution access or a scoped contribution path; requires a 48h decisionquestionUsage or project-policy question

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions