Skip to content

Commit 035baa0

Browse files
authored
Merge pull request #42 from MiniMax-AI-Dev/fix/nullish-coalescing-zero-values
fix(commands): use ?? instead of || for numeric flag defaults
2 parents 2a40b30 + 3161516 commit 035baa0

5 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/commands/image/generate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export default defineCommand({
5555
model: 'image-01',
5656
prompt,
5757
aspect_ratio: (flags.aspectRatio as string) || undefined,
58-
n: (flags.n as number) || 1,
58+
n: (flags.n as number) ?? 1,
5959
};
6060

6161
if (flags.subjectRef) {

src/commands/music/generate.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ export default defineCommand({
123123
lyrics,
124124
audio_setting: {
125125
format: (flags.format as string) || 'mp3',
126-
sample_rate: (flags.sampleRate as number) || 44100,
127-
bitrate: (flags.bitrate as number) || 256000,
126+
sample_rate: (flags.sampleRate as number) ?? 44100,
127+
bitrate: (flags.bitrate as number) ?? 256000,
128128
},
129129
output_format: outFormat,
130130
stream: flags.stream === true,

src/commands/speech/synthesize.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,15 @@ export default defineCommand({
6464
text,
6565
voice_setting: {
6666
voice_id: voice,
67-
speed: (flags.speed as number) || undefined,
68-
vol: (flags.volume as number) || undefined,
69-
pitch: (flags.pitch as number) || undefined,
67+
speed: (flags.speed as number) ?? undefined,
68+
vol: (flags.volume as number) ?? undefined,
69+
pitch: (flags.pitch as number) ?? undefined,
7070
},
7171
audio_setting: {
7272
format: (flags.format as string) || 'mp3',
73-
sample_rate: (flags.sampleRate as number) || 32000,
74-
bitrate: (flags.bitrate as number) || 128000,
75-
channel: (flags.channels as number) || 1,
73+
sample_rate: (flags.sampleRate as number) ?? 32000,
74+
bitrate: (flags.bitrate as number) ?? 128000,
75+
channel: (flags.channels as number) ?? 1,
7676
},
7777
output_format: outFormat,
7878
stream: flags.stream === true,

src/commands/text/chat.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export default defineCommand({
123123
const body: ChatRequest = {
124124
model,
125125
messages,
126-
max_tokens: (flags.maxTokens as number) || 4096,
126+
max_tokens: (flags.maxTokens as number) ?? 4096,
127127
stream: shouldStream,
128128
};
129129

src/commands/video/generate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export default defineCommand({
108108
}
109109

110110
// Default: poll until completion
111-
const pollInterval = (flags.pollInterval as number) || 5;
111+
const pollInterval = (flags.pollInterval as number) ?? 5;
112112
const taskUrl = videoTaskEndpoint(config.baseUrl, taskId);
113113

114114
const result = await poll<VideoTaskResponse>(config, {

0 commit comments

Comments
 (0)