Skip to content

Commit 3161516

Browse files
Elaine YINclaude
authored andcommitted
fix(commands): use ?? instead of || for numeric flag defaults
|| treats 0 as falsy, silently replacing explicit zero values with defaults. --max-tokens 0 became 4096, --speed 0 vanished entirely. Affects 5 commands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 920273d commit 3161516

5 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/commands/image/generate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export default defineCommand({
5050
model: 'image-01',
5151
prompt,
5252
aspect_ratio: (flags.aspectRatio as string) || undefined,
53-
n: (flags.n as number) || 1,
53+
n: (flags.n as number) ?? 1,
5454
};
5555

5656
if (flags.subjectRef) {

src/commands/music/generate.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ export default defineCommand({
123123
lyrics,
124124
audio_setting: {
125125
format: (flags.format as string) || 'mp3',
126-
sample_rate: (flags.sampleRate as number) || 44100,
127-
bitrate: (flags.bitrate as number) || 256000,
126+
sample_rate: (flags.sampleRate as number) ?? 44100,
127+
bitrate: (flags.bitrate as number) ?? 256000,
128128
},
129129
output_format: outFormat,
130130
stream: flags.stream === true,

src/commands/speech/synthesize.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,15 @@ export default defineCommand({
6565
text,
6666
voice_setting: {
6767
voice_id: voice,
68-
speed: (flags.speed as number) || undefined,
69-
vol: (flags.volume as number) || undefined,
70-
pitch: (flags.pitch as number) || undefined,
68+
speed: (flags.speed as number) ?? undefined,
69+
vol: (flags.volume as number) ?? undefined,
70+
pitch: (flags.pitch as number) ?? undefined,
7171
},
7272
audio_setting: {
7373
format: (flags.format as string) || 'mp3',
74-
sample_rate: (flags.sampleRate as number) || 32000,
75-
bitrate: (flags.bitrate as number) || 128000,
76-
channel: (flags.channels as number) || 1,
74+
sample_rate: (flags.sampleRate as number) ?? 32000,
75+
bitrate: (flags.bitrate as number) ?? 128000,
76+
channel: (flags.channels as number) ?? 1,
7777
},
7878
output_format: outFormat,
7979
stream: flags.stream === true,

src/commands/text/chat.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export default defineCommand({
123123
const body: ChatRequest = {
124124
model,
125125
messages,
126-
max_tokens: (flags.maxTokens as number) || 4096,
126+
max_tokens: (flags.maxTokens as number) ?? 4096,
127127
stream: shouldStream,
128128
};
129129

src/commands/video/generate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export default defineCommand({
100100
}
101101

102102
// Default: poll until completion
103-
const pollInterval = (flags.pollInterval as number) || 5;
103+
const pollInterval = (flags.pollInterval as number) ?? 5;
104104
const taskUrl = videoTaskEndpoint(config.baseUrl, taskId);
105105

106106
const result = await poll<VideoTaskResponse>(config, {

0 commit comments

Comments
 (0)