Repository navigation
Move Core-Runtime wire types into the protocol package - #837
Merged
Merged
Conversation
SaladDay
force-pushed
the
move-runtime-wire-types-into-protocol
branch
from
October 23, 2026 19:22
ea0caf8 to
51af011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the wire types and validators that
internal/agentdaemon/protoborrowed from other packages into the protocol package.protonow ownsSkillMetadata,PluginMetadata,CapabilitySources,InstalledSkill,PluginMCPServer,ValidateCapabilitySourcesandValidateSourceDirectories(newcapability_sources.go). It no longer importsagentcapabilities,agentskilloragentplugin, which keep only install, bundle and upload logic and use the proto types. JSON tags are moved verbatim, so field names are unchanged; the existing proto tests pass.runtimedevice.KindCapabilitiesand its explicit projection inruntimegatewayare unchanged: the persisted boolean form is a legitimate projection of the wire tri-state type, andTestCapabilityProjectionCoversEveryFieldchecks that they stay in step.docs/runtime-protocol.md(and zh) now describe the Subagent message families and the finite workspace read error codes.read_unsupportedis removed from Core's accepted rejected-read codes. Only the Harness-level read path inapps/daemon/internal/dispatchproduced it, and that path is deleted by Remove Harness-level workspace reads #834, so this lands together with Remove Harness-level workspace reads #834. Proto itself never defined the code.Checks:
go vetfor the root andservices/coremodules (andGOOS=windowsfor the daemon), tests for the touched root packages, daemon packages and Core packages, and the Core layering test. The translation hash check passes; the structure subtest ofwebsite/tests/translations.test.mjscould not run here becausevitepressis not installed.