Repository navigation
Delete unused Core Go code - #831
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
delete-unused-core-go-code
branch
3 times, most recently
from
October 23, 2026 18:56
1aac926 to
5d73560
Compare
- Delete Observe from workspacefs.Control; Core never called it through the interface. - Keep the NFS Filesystem.Observe method, which Resolve calls directly. - Drop the test fixtures' Observe methods. - Update the workspace provider protocol and its Chinese translation.
- Remove the unreachable responseHeadersWithErrors and microsandbox Labels. - Remove domain Reader interfaces used only in assertions, and narrow sessions.Reader and its families to the methods called through it. - Remove interface methods never called through their interface in deployment, vaults and skills. - Remove the device WorkspaceID chain, the bootstrap workspace_id and protocol_version fields, and the unread heartbeat ts, active_requests and daemon_version fields (Runtime protocol 0.22.0). - Remove write-only fields: NewAllocation.EnvironmentID, SweepResult times, EnrolledRuntimeBinding.SessionID, EnvironmentFileWrite.EnvironmentID and SessionID; move TurnEvent into its only test. - Remove the request_timeout provider observation category and the system provisioning step. - Drop the public_execution_turns view and the request_timeout error-code constraint value in a forward migration. - Correct the Core errors anchor and the Core implementation notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure deletion of Core Go code, fields, queries and doc text that nothing uses. Two commits: the Core workspace protocol change (
workspacefs.Control.Observe) stands alone.Removed:
responseHeadersWithErrors, microsandboxLabels.Readerinterfaces used only invar _assertions (adminaudit, agents, environmenttemplates, files, modelconfiguration, projects, writeaudit); the unused sessions reader families (Admin, Artifact, ExecutorCredential, Item, Subagent) andListSessions,SessionStreamSnapshot,SessionEventCursor,ListSessionEvents,GetTurnDiagnosticsSnapshot,GetManagedSessionArchive,ListTurnsandArchivedCancellationReceiptfrom the interfacesessions.Readercomposes;deploymentSampleHostHistory/NodeAllocations,vaultsGetVaultandskillsVersioninterface methods.WorkspaceIDchain and the bootstrapworkspace_id/protocol_versionfields; the unread heartbeatts,active_requests,daemon_version(Runtime protocol 0.22.0) andHeartbeatStatus.Liveness.NewAllocation.EnvironmentID,SweepResulttimes (andSampler.now),EnrolledRuntimeBinding.SessionID,EnvironmentFileWrite.EnvironmentID/SessionID;TurnEventmoved into its integration test.request_timeoutprovider observation category and diagnostic code, and thesystemprovisioning step.000004: drops viewpublic_execution_turnsand therequest_timeoutvalue ofdeployment_provider_error_code.workspacefs.Control.Observe(own commit); the NFSFilesystem.Observestays becauseResolvecalls it.Kept (production uses or tests are the only observation of persisted state):
coreErrorResponse(type-assertion marker),Policy.Declarations(10+ execution and integration tests inject custom Harness declarations),Allocation.ObservationError/ComputeWakeRequestedandEnvironmentRun.Turn(asserted by concurrency and diagnostic tests),StoredNode.ReadyGeneration(read in nodes.go),EnrollmentResponse.Connected/ProviderReady(read by deploy/node/node_install.py), provisioning stepfile(produced by runtime initialization),vaults.Reader.ListVaults/GetCredential/ListCredentials(called through the interface by pg tests / service).Checks
coreErrorResponseremains, nothing newly exposedNeed help on this PR? Tag
@codesmith-botwith what you need.