Repository navigation
Remove handling of legacy Session deletion markers - #799
Merged
Merged
Conversation
SaladDay
force-pushed
the
remove-legacy-session-deletion-markers
branch
from
October 20, 2026 07:04
4ec3199 to
dfd1208
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session deletion is idle-only.
DeleteSessionholds the Session row lock and refuses a Session with queued, in-progress or waiting Turns or pending input. Admission takes the same lock and checks visibility. So no current path leaves a deleted Session with pending work, and that state could only come from markers committed by older releases.ListExecutionWorkclause that exempted non-queued Turns of deleted Sessions.commitLegacyDeletiontest helper and the tests or cases that only exercised such markers. The current path stays covered by the existing deletion and worker tests.Need help on this PR? Tag
@codesmith-botwith what you need.