Repository navigation
Install bundled native installers from the offline archive - #790
Merged
Merged
Conversation
The Core image carries only the native installer catalog. install.py never copied the offline archive's native installers into the installation, so a source build with a catalog left Core failing to start, and offline releases redirected self-hosted machines to GitHub. install.py now copies them into native-installers/<commit>, binds that directory into Core and removes other releases' copies after a successful start. oac upgrade drops the bind and the copy together with the node payload bind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Core image carries only
native-installers/catalog.json. Without a release base URL the catalog has no download URLs, so Core requires the archives at/opt/oac/native-installers/<platform>.tar.gz. The offline archive ships them, butinstall.pynever installed them:OAC_NATIVE_INSTALLER_BUILD_DIR(Develop → Install a checkout without publishing a release) left Core in a restart loop:open /opt/oac/native-installers/linux-amd64.tar.gz: no such file or directory.Change
install.pycopies the bundle'snative-installers/into<installation>/native-installers/<commit>, makes it readable by Core, binds it read-only at/opt/oac/native-installers, and removes other releases' copies after a successful start.oac upgradedrops that bind and directory together with the existing/node-payloadbind when an offline installation moves to a published release.Validation
python3 -m unittest deploy/test_install_source.py(13 tests, new: install + upgrade prune)go test ./services/core/cmd/oac/andgo vetinstall.py, Core is healthy with the archives bound.Need help on this PR? Tag
@codesmith-botwith what you need.