Repository navigation
Map model token limits to native settings - #786
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
force-pushed
the
map-model-token-limits-to-native-settings
branch
from
October 19, 2026 19:06
472880d to
68774d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each Harness now receives the model provider's token limits through its native setting, and Core rejects a limit the Harness cannot run.
context_window→model_context_window. Codex has no native output limit, so a setmax_output_tokensreturnsmodel_provider_token_limits_invalid.CLAUDE_CODE_MAX_CONTEXT_TOKENSandCLAUDE_CODE_MAX_OUTPUT_TOKENS. Native uses the first only for a model it does not know and caps the second at the model's limit.limit.contextandlimit.output, unchanged.MaxOutputTokensis the only source of this fact./core/v1/harnessesprojects it asmodel_configuration_support.accepts_max_output_tokens, and Web shows the Max output tokens field only when it is true.CLAUDE_CODE_MAX_*_TOKENS, so only the provider sets them; the client accepts an output limit without a context window, as Core does.Release notes: a Codex Session, saved Agent or deployment default that stores
max_output_tokenswas accepted and ignored; it now fails at use withmodel_provider_token_limits_invalid. Remove the field.Need help on this PR? Tag
@codesmith-botwith what you need.