Repository navigation
Run MiniMax Code reasoning and MCP natively - #775
Merged
Merged
Conversation
SaladDay
force-pushed
the
run-minimax-code-reasoning-and-mcp-natively
branch
2 times, most recently
from
October 19, 2026 10:26
f5736f1 to
b23d3ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax Code now runs
reasoning.effort, service-origin MCP and plain text input as a local run does.reasoning.effort(nonethroughmax) maps to the native custom model's thinking options. Natively a model with effort options is advertised only as itsthinkingvariant, and a selected variant takes no default effort, so the adapter selects that variant and sets ACPthinkingEffort. With no effort, nothing is sent and the native default applies. Native turns the effort into the provider field (output_config.effortfor Anthropic,reasoning_effortorreasoning.effortfor OpenAI protocols);nonebecomes native disabled thinking.environment: none. The adapter passes the servers in the ACP Session'smcpServers, as it already does for environment-origin servers on a workspace. The shared origin rule is unchanged."\n\n"to every message. The empty block is kept only for text starting with/, which native ACP would otherwise run as a command.bypassPermissions, so MCP tools, including those onenvironment: none, run without approval prompts instead of being cancelled. MCP servers are resolved once in the executor for both profiles, and the adapter's extra check onallowed_tools/require_approvalis gone because the declaration already rejects them.logLevel,builtinTools: [], text-profileskills: [],tool_call: true), and comments and the guide now describe native behavior correctly.Docs: harness-capabilities.md, index.md, model-execution.md, the MiniMax Code guide, with zh mirrors.
Tests: unit tests for the effort config, service-origin MCP on
noneand the prompt blocks, and a gated live test against the real provider (traffic through a local recording proxy, so the key never reaches a log). It verifiedoutput_config.effort: highon the wire, an MCP tool listed, called and observed onnone, and the user text arriving unchanged. A manual run withnoneshowedthinking: {type: disabled}on the wire. The existing executor-reuse and workspace-tools live tests still pass.Need help on this PR? Tag
@codesmith-botwith what you need.