Skip to content

Run MiniMax Code reasoning and MCP natively - #775

Merged
SaladDay merged 1 commit into
mainfrom
run-minimax-code-reasoning-and-mcp-natively
Oct 19, 2026
Merged

SaladDay merged 1 commit into
mainfrom
run-minimax-code-reasoning-and-mcp-natively

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

MiniMax Code now runs reasoning.effort, service-origin MCP and plain text input as a local run does.

  • reasoning.effort (none through max) maps to the native custom model's thinking options. Natively a model with effort options is advertised only as its thinking variant, and a selected variant takes no default effort, so the adapter selects that variant and sets ACP thinkingEffort. With no effort, nothing is sent and the native default applies. Native turns the effort into the provider field (output_config.effort for Anthropic, reasoning_effort or reasoning.effort for OpenAI protocols); none becomes native disabled thinking.
  • Service-origin HTTP MCP works on environment: none. The adapter passes the servers in the ACP Session's mcpServers, as it already does for environment-origin servers on a workspace. The shared origin rule is unchanged.
  • Plain input is sent as one ACP text block. ACP joins blocks with a blank line, so the old trailing empty block appended "\n\n" to every message. The empty block is kept only for text starting with /, which native ACP would otherwise run as a command.
  • Permission mode is bypassPermissions, so MCP tools, including those on environment: none, run without approval prompts instead of being cancelled. MCP servers are resolved once in the executor for both profiles, and the adapter's extra check on allowed_tools/require_approval is gone because the declaration already rejects them.
  • Dead native settings are removed (logLevel, builtinTools: [], text-profile skills: [], tool_call: true), and comments and the guide now describe native behavior correctly.

Docs: harness-capabilities.md, index.md, model-execution.md, the MiniMax Code guide, with zh mirrors.

Tests: unit tests for the effort config, service-origin MCP on none and the prompt blocks, and a gated live test against the real provider (traffic through a local recording proxy, so the key never reaches a log). It verified output_config.effort: high on the wire, an MCP tool listed, called and observed on none, and the user text arriving unchanged. A manual run with none showed thinking: {type: disabled} on the wire. The existing executor-reuse and workspace-tools live tests still pass.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@SaladDay
SaladDay force-pushed the run-minimax-code-reasoning-and-mcp-natively branch 2 times, most recently from f5736f1 to b23d3ab Compare October 19, 2026 10:26
@SaladDay
SaladDay merged commit 29792e7 into main Oct 19, 2026
25 checks passed
@SaladDay
SaladDay deleted the run-minimax-code-reasoning-and-mcp-natively branch October 19, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant