Repository navigation
Run MiniMax Code with its native tools - #766
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax Code on a workspace placement now runs its own builtin tools in the workspace, as it does locally. The
oac_workspaceMCP bridge, which re-exposed six workspace tools while the native ones were withheld, is deleted along with the native tool-gate patch. Its original reasons, a native sandbox that covered only bash and a native cwd outside the workspace, no longer hold.What changes
read,write,edit,bash,grep,glob,todowriteandweb_fetchwithbypassPermissions. Subagent children get the same native tools within their native profile ceilings. The Runtime's frozen tool environment now reaches tools through the native process environment.task_output, so Subagent results stay readable. The ACP initialize handshake (oac/subagentsversion 2) reports the switch, and the adapter rejects a CLI that does not report it off. The companion readiness protocol goes to 3. The Subagent concurrency patch is unchanged.website_deploy.beta.browserUseToolingis removed.environment: nonestill has no tools or Skills.web_search: disabledalso removesweb_fetch, as it removes Claude Code'sWebFetch. An omitted control keeps it.bashcalls become command observations with the Session's workspace as cwd. The exit code is reported only when the native result carries one, and failure prose is not parsed.web_fetchcalls becomeweb_searchobservations with anopen_pageaction.OAC_RUNTIME_MCODE_COMPANION(the companion directory) replacesOAC_RUNTIME_MCODE_WORKSPACE_BRIDGE. The daemon derives it from the installation at start, so nothing persisted changes.bridge.mjs,worker.ts,native-pi-tools.ts,tool-executor.mjs,launch.mjs,build.mjs, their tests and the companion's npm package and lock. Also the bridge steps in the build, installer and manifest scripts, and theoac_workspacereservations in the declaration and adapter.The native data directory, including the generated configuration that holds the provider credential, is readable by native tools. The bridge already inherited it, and the deploy guide now documents it as for Claude Code.
Checks
go testforapps/daemon/internal/agent/mcode,apps/daemon/internal/cliandinternal/harnessconfig/...;go build ./...;go vet ./apps/daemon/.... Mutation checks: removing the handshake check, the exit-code read, theweb_fetchremoval, the background-bash env, the real cwd or thenoneSkill ceiling each fails a test.make check-mcode-harness, with the patch test against the pinned source (3/3), plusmake check-docs,make check-harness-catalogand the website translation tests.TestNativeMCodeWorkspaceTools, with Subagents enabled, checks that:sleep 20completes in the foreground andrun_in_backgroundis refused;web_fetchis present by default and absent withdisabled, andwebsite_deploy, ask-user, mavis andweb_searchnever appear;nonehas no builtin tools.TestNativeMCodeExecutorReusealso passes.Need help on this PR? Tag
@codesmith-botwith what you need.