Repository navigation
Fix Claude directory links and missing history - #764
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two Claude Code workspace behaviors that made the live acceptance test fail on
main. With both fixed, the test passes.lstatand rejects a link the same way it rejects a regular file, as the list files contract says: links are never followed, and on the Claude path a regular file or symbolic link returns 503. The bridge's unit test asserted the old behavior and now asserts the rejection.history_unavailable. On an Executor, the bridge emitted the history error through the Turn-scoped emitter before any Turn was bound. That emitter threw, so preparation failed withexecution_failed. The error now goes through the owner emitter, which the Go Executor already maps tohistory_unavailable.Checks
pnpm testinpackages/claude-sdk-adapter: 180 passed. The new Executor test fails without the fix, and so does the updated listing test.go vetandgo testforapps/daemon/internal/agent/claudesdk;make check-docs.TestLiveClaudeWorkspaceFactorypasses in full withMiniMax-M3through MiniMax's Anthropic endpoint, Claude Code 2.1.269 and Node 22.22.2, with no test edits. That covers native commands, cancellation, fresh-process continuation, directory listing denials and missing history.Need help on this PR? Tag
@codesmith-botwith what you need.