Repository navigation
fix(core): revoke live stream access and settle failed preparation - #240
Merged
Merged
Conversation
SaladDay
marked this pull request as ready for review
September 29, 2026 16:16
…preparation-fixes-20260929 # Conflicts: # apps/docs/content/guide-sources.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing Session streams retained access after Project-key revocation, and confirmed Runtime preparation failures kept input pending until the five-minute deadline. Revalidate live-stream authority with the existing resolver and settle a confirmed pre-admission failure through the existing reservation lifecycle. New input can proceed after the local cause is fixed; connection loss, capacity rejection and uncertain cleanup remain retryable.
Changes stay in Core authentication, preparation settlement and their existing projections. No Harness/provider branches or Runtime wire additions. The database change allows the existing
runtime_preparation_faileddiagnostic category; generated SQL, API descriptions and documentation are updated.Focused remote tests passed for real-database key revocation/Project archival, continuously busy streams and resolver failure, preparation failure/new admission, uncertain-failure retries, cancellation/newer-input preservation, and existing stream/diagnostic behavior. Fresh independent blind review found no actionable issue.
GitHub CI on
0d30a539passed the stock fullcheck, official-client, and native Linux/Windows/macOS jobs. Remote gate components also passed: documentation/distribution, generated SQL, Go/Core/database suites, Claude adapter, Core Web (86 browser tests), example application (10 browser tests), and MiniMax companion. The final busy-stream test passed 10 consecutive runs. Independent review of the final complete diff found no actionable issue.Local gate attempts encountered test-host issues: an evicted temporary sqlc executable, missing Chrome channel, and a download proxy incompatible with the browser launcher. These were corrected in the acceptance environment, and the affected targets were rerun successfully; no product workaround was added.
This does not address artifact-result semantics, download recovery, unmeasured SSE polling load or engine-specific model error latency.