Repository navigation
fix(harness): restore Claude preparation and MiniMax Skill loading - #239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Claude preparation failed under root because the CLI rejects bypass mode. Use its existing permission callback so ordinary execution, cancellation and resume follow the same adapter path. MiniMax now exposes the native Skill loader only for Skills selected by the frozen capability snapshot. Correct the template setup_commands documentation example.
Validation: remote Go adapter suites and all 166 Claude SDK tests passed; the pinned MiniMax native companion rebuilt successfully. Isolated Linux live-model checks passed for Claude Bash execution, daemon restart/continuation and cancellation, plus MiniMax native Skill loading before and after restart. The documented template payload returned 201. A fresh independent blind review found no actionable issue.
Remote make check passed through Core Web acceptance (86 tests). Its example browser target could not start because this server has cached Chromium but no Chrome channel. The same 10 example browser tests then passed with a test-only external config selecting cached Chromium, and the remaining MiniMax gate passed. The earlier installer port collision also passed on rerun. The stock full command therefore did not exit green on this host; every gate was exercised, with this browser environment adjustment. No native macOS or Windows live-model validation was performed for this change.
Core and public protocols are unchanged. MiniMax inline reasoning and file-tool event limitations remain documented; this change does not patch upstream model requests or fabricate command events.
GitHub CI on commit cbb91d7 passed: full check, official-client, and native Linux, Windows and macOS platform jobs. PR: #239.