Repository navigation
feat(example): complete Parsar session and workspace flows - #238
Merged
Merged
Conversation
SaladDay
marked this pull request as ready for review
September 30, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsar now uses Core's public native installation commands for user-machine Sessions, honors the selected Provider for Codex and Claude workspace Sessions, and exposes the upload → Agent execution → artifact download workflow through the public Files and Artifacts APIs. Unsupported bindings are explained before creating a Session; combinations that still use deployment model connections say so explicitly.
Uploads are bounded to 5 MiB, insert a workspace-relative path into the draft, and never send a message automatically. Unsent drafts persist per Session in the browser tab, including after navigation or reload. Artifact downloads preserve binary bytes and report failures within the dialog. The example is maintained independently in this repository, with obsolete external Parsar provenance narrative removed and license notices retained. It remains a local SQLite product client; no administrator credentials, Core changes, new protocol or execution service are introduced.
Independent blind review completed with no actionable findings after corrections.
Validation: example typecheck, 17 backend tests, production build and 14 Playwright tests passed. A real Linux self-hosted Claude/MiniMax model read an uploaded CSV, wrote the sum into an output artifact, and the browser downloaded the verified result
59. Desktop/mobile file-dialog views were inspected. Native macOS/Windows execution was not exercised; their onboarding UI is fixture-tested.make checkwas attempted and stopped in check-distribution because the installed Go toolchain cannot parse the repository's required Go 1.26.8 version.Uploads accommodate Core file-write latency, report uncertain results with the destination path, and bound generated filenames by UTF-8 bytes. After integrating current main, the complete example gate passed again and a fresh independent review found no actionable issues.