Repository navigation
fix(install): preserve standard proxies during node installation - #235
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
SaladDay
marked this pull request as ready for review
September 29, 2026 14:50
…oxy-20260929 # Conflicts: # apps/docs/content/guide-sources.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node installation lost HTTP/HTTPS proxy settings at sudo and again when switching to the service account, so release downloads could stall or fail.
Preserve only the six standard HTTP/HTTPS proxy and NO_PROXY environment names across those boundaries. Normalize uppercase/lowercase settings consistently for curl, Python and Go registration (an explicitly set lowercase value wins, including empty). Bootstrap download errors use fixed text so malformed authenticated proxy URLs are not printed. Node service permissions and runtime network configuration remain unchanged.
Historical validation at
f558cb6d(before the current-main integration):The live acceptance used the current installer/command with the published release matching mx1 Core; it did not rebuild Runtime images or qualify another release. Only mx2's old node/VMs were stopped, with complete state preserved. The temporary artifact origin was restored to the normal Core source and direct installer reuse verified before removing temporary proxy/trust/account fixtures. mx1 services were not stopped.
Operator and maintainer documentation describe the allowlist, precedence, sudo policy requirements and installation-only scope.
Current-main integration (
d3e7f6b0, based on98de4b5c):make checkpassed documentation, distribution, sqlc, Go/Core/PostgreSQL, Claude adapter/packaging, TypeScript, unit and Web build gates, then stopped at browser startup because the configured Chrome channel is absent. A cached-Chromium attempt also stopped at launch due to missinglibatk-1.0.so.0; no browser assertions ran in either attempt. Final-commit GitHub CI passed the completemake check(including Web and example browser acceptance) and daemon build.The integration run made no deployment, service, sandbox or stored-data changes. Historical live proxy acceptance above remains scoped to its original artifacts; it is not qualification of a new release package.
Concurrent main change
1460589fremoves historical installer code. Its changed files do not overlap the proxy implementation; the shared maintainer documentation edits affect separate sections. GitHub reports the PR mergeable.