Skip to content

Fix reset completion for custom E2B endpoints - #233

Merged
sam2tom merged 1 commit into
mainfrom
codex/e2b-reset-endpoint-fix
Sep 30, 2026
Merged

sam2tom merged 1 commit into
mainfrom
codex/e2b-reset-endpoint-fix

Conversation

@sam2tom

@sam2tom sam2tom commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Clear the custom E2B API URL and data-plane domain in the same CompleteSandboxReset update that clears provider_kind.
  • Regenerate sqlc output and add a database-backed regression test for a force reset of a custom E2B endpoint.

Failure observed

On the Docker test host, generation 4 reached zero allocations and pending Sessions, but reset completion retried every five seconds. The current row had provider_kind='e2b' and nonempty endpoint fields. The reset update set provider_kind='' without clearing those fields, violating runtime_deployment_e2b_endpoint_check.

Verification

  • make sqlc-generate
  • go test ./services/agents-api/internal/store -run 'TestSandboxReset|TestSandboxE2BEndpoint' -count=1 -timeout=5m against a dedicated temporary PostgreSQL database: passed.
  • git diff --check: passed.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@sam2tom
sam2tom merged commit 478b16e into main Sep 30, 2026
3 checks passed
@SaladDay
SaladDay deleted the codex/e2b-reset-endpoint-fix branch October 7, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant