Repository navigation
refactor: remove model API proxy and require native protocols - #224
Merged
Merged
Conversation
SaladDay
marked this pull request as ready for review
September 29, 2026 10:19
SaladDay
changed the title
This comment has been minimized.
This comment has been minimized.
…design-20260929 # Conflicts: # apps/docs/content/docs/bootstrap-projects-keys.mdx # apps/docs/content/docs/concepts.mdx # apps/docs/content/docs/configure.mdx # apps/docs/content/docs/index.mdx # apps/docs/content/docs/install.mdx # apps/docs/content/docs/public-api.mdx # apps/docs/content/docs/quickstart.mdx # apps/docs/content/docs/sessions.mdx # apps/docs/content/docs/troubleshooting.mdx # apps/docs/content/docs/user-guide.mdx # apps/docs/content/guide-sources.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models now connect directly using protocols supported natively by the selected Harness: Responses for Codex, Anthropic for Claude Code, and all three existing protocols for MiniMax Code. Remove the embedded model HTTP proxy, conversion machinery and CLIProxyAPI dependency. Unsupported configurations fail explicitly without rewriting stored Session snapshots.
Define the shared model configuration contract in
internal/harnessconfig/harness.go. Core and Runtime consume the same declaration; Runtime registration binds it to direct, preparation and Executor entry points. Validate model identity, provider and native parameters before native work. Claude's private bridge receives compiled native options and retains structural checks without duplicating Go's parameter semantics.Web uses the single ordered protocol list and rejects unsupported stored selections. Preserve encrypted credentials, atomic configuration replacement and native execution/cancellation. Broader unified generation fields remain design-only and extend the existing contract.
Validation: targeted Go regression suites; client 755 tests and typecheck; Web typecheck and browser checks; Claude bridge 166 tests; OpenAPI and documentation verification. Fresh independent review found no in-scope issues. Rebuilt native Claude acceptance passed tool calls, failed tool results, cancellation, continuation and cold recovery. Full
make check, official-client acceptance and Linux/macOS/Windows CI passed on1b1d6c2622a4e235f8e93d22a8473ef19ea1a154.