Repository navigation
Unify model configuration across Core and harness execution - #222
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment defaults and public Agent/Session inputs now resolve one model configuration: provider connection, model and adapter-owned native parameters. Sessions freeze the result; changing a model or provider clears inherited native parameters unless explicitly supplied. Self-hosted Sessions never read deployment defaults.
Harness declarations drive both Core admission and Runtime preparation. Native parameters reach the SDK or native Turn settings, while unqualified conversion requirements are rejected before submission or upstream forwarding. Provider credentials remain encrypted and write-only. The Web form uses the shared declarations.
The Core administration resource is now
/core/v1/harnesses/{harness}/model-configuration; the old/model-providerroute is removed.Validation:
make checkin CI, including browser acceptance; official-client and Linux/macOS/Windows native checks.effort: low: parameter snapshot, function results, cancellation, continuation and Runtime restart recovery passed. This does not claim that the model precisely obeyed the requested effort.