storgae clean up#698
Open
Nabeelahh wants to merge 1 commit into
Open
Conversation
Contributor
|
Tight, focused cleanup on the escrow error surface and a small staking test follow-up. Easy to review. Merging. ✅ |
Contributor
|
🟡 Holding for author coordination. This PR and #677 both modify the same files ( |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #511
Summmary
This PR implements a long-overdue storage optimization mechanism for the escrow contract. Currently, escrow data (documents, conditions, signatures, audit logs) persists indefinitely after completion, causing unnecessary on-chain storage bloat. This change introduces a cleanup mechanism that removes detailed escrow data while preserving essential information for compliance and historical reference.
Key Changes
New Features
cleanup_escrow(escrow_id)- New public message allowing any participant or admin to clean up a completed escrowget_escrow_summary(escrow_id)- New query to retrieve summary information for cleaned-up escrowsValidation Rules
Completed,Released, orRefundedPending,InProgress,Disputed)Performance Impact
Testing