fix: resolve 4 issues - security, a11y, localStorage, modal ARIA#542
Open
DanielCharis1 wants to merge 2 commits into
Open
fix: resolve 4 issues - security, a11y, localStorage, modal ARIA#542DanielCharis1 wants to merge 2 commits into
DanielCharis1 wants to merge 2 commits into
Conversation
…alStorage, and modal ARIA Fixes MettaChain#432, MettaChain#436, MettaChain#437, MettaChain#438 MettaChain#438 - security: Replace Math.random in ID/hash generation with crypto.randomUUID - Created src/utils/secureId.ts with generateSecureId, generateTimestampedId, generateMockTxHash, etc. - Updated 22 files: auditLogger, errorReporting, errorMonitoringService, structuredLogger, logger, kyc, cacheManager, propertyService, notificationService, offlineTransactionQueue, batchTransaction, secondaryMarketService, transactionMonitor, useSearchHistory, comparisonHistoryStore, paperTradingStore, useRewardDistribution, PropertyCard, page.tsx MettaChain#436 - bug: DomainWarningBanner auto-redirect without consent - Created src/components/DomainWarningBanner.tsx - Shows manual consent button instead of auto-redirect - Includes aria-live region for screen reader announcements MettaChain#432 - bug: localStorage writes unsanitised for BigInt/circular values - Created src/utils/safeLocalStorage.ts with safe JSON replacer/reviver - Handles BigInt, circular refs, Date, RegExp, Map, Set - Updated propertyCache.ts, cacheManager.ts, useSearchHistory.ts to use safeLocalStorage MettaChain#437 - bug: inconsistent modal focus management and ARIA roles - Updated WalletModal.tsx to use Radix Dialog (Dialog, DialogContent, DialogHeader, DialogTitle) - Updated TransactionProgress.tsx to use Radix Dialog - Component now gets proper focus trap, aria-modal, and aria-labelledby from Radix
|
@DanielCharis1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #432 #436 #437 #438
closes #432
closes #436
closes #437
closes #438