Conversation
Endpoints that support file uploads (e.g. creator, issue) require multipart/form-data even when no file is present. Previously, mokkari fell back to JSON when no image file was attached, causing a 415 Unsupported Media Type error. Now all object payloads use form data, with None values stripped and nested dicts JSON-encoded as strings.
When a RateLimitError occurs mid-pagination, sleep for the retry_after duration (plus a small buffer) and retry the current page rather than bubbling the error up and forcing the caller to restart the entire paginated fetch from the beginning. Co-authored-by: Copilot <copilot@github.com>
Endpoints without an image field (e.g. series, universe) require JSON, while endpoints with an image field (creator, issue, team, character, arc) require multipart/form-data even when no file is uploaded.
bpepple
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multipart/form-datafor endpoints that have animagefield (creator, issue, team, character, arc). Endpoints without an image field (series, universe, etc.) now correctly send JSON, preserving null values and nested objects. Also stripsNonevalues from multipart payloads, which can't be represented in form data.ApiErrormessages to make HTTP errors easier to diagnose.