Conversation
darkseid's Price class now takes an ISO 4217 currency code directly instead of a country code, so remove the map_currency_to_country conversion and pass price_currency through unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
map_currency_to_countryhelper and passprice_currencydirectly toPrice, matching darkseid's updatedPrice(amount, currency)signature which now expects an ISO 4217 currency code instead of a country codetest_metadata_mapper_map_currency_to_countrytest and update price assertion to checkcurrency == "USD"instead ofcountry == "US"