fix: take the issuer DID from values instead of deriving it - #1
Merged
Conversation
`jadtx.issuerDid` rebuilt the platform's old in-cluster DID form (did:web:issuerservice.<ns>.svc.<clusterDomain>%3A10016:issuer) — a copy of a rule that lives in core-platform-distribution, which this chart cannot see because it is a separate release. When the platform moved its issuer DID onto the gateway hostname, this copy did not follow, and the dataspace profile's credentialSpecs pinned a credential issuer that no longer existed. Onboarding then failed at credential verification, far from the cause. The DID is now a plain `issuer.did` value, `required` so an empty one fails at template time rather than seeding a broken profile. It must match what the platform minted; the value's comment gives the command to read it back off the deployment. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
wolf4ood
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jadtx.issuerDidno longer derives the trusted-issuer DID from the chart's own FQDN helper; it now takesissuer.didverbatim from values (with arequiredguard so a missing value fails at template time).issuer.didtovalues.yaml(defaultdid:web:issuer.cxve.localhost:issuer) with documentation on why it must match the DID core-platform-distribution minted for the issuer participant context, and how to read the live value off a deployment.🤖 Generated with Claude Code