Add solana-test-validator-up package#8826
Open
ulissesferreira wants to merge 2 commits into
Open
Conversation
ulissesferreira
temporarily deployed
to
default-branch
GitHub Actions
Inactive
Contributor
Author
|
Code sync follow-up:
|
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
@metamask/solana-test-validator-upto the core monorepo using the generated package structure, then replaces the scaffold with the existing Solana/Agave runtime installer implementation.Ownership follows the runtime tooling/platform pattern and includes Networks, matching the Tron Snap ownership direction.
Changes
packages/solana-test-validator-up.solana-test-validator-upCLI bin fromdist/bin/solana-test-validator-up.mjs.teams.jsonownership.Verification
yarn workspace @metamask/solana-test-validator-up run buildyarn workspace @metamask/solana-test-validator-up run testyarn eslint packages/solana-test-validator-upyarn constraintsyarn lint:misc --check packages/solana-test-validator-up/package.json packages/solana-test-validator-up/README.md packages/solana-test-validator-up/src/index.ts packages/solana-test-validator-up/src/install.ts packages/solana-test-validator-up/src/install.test.ts packages/solana-test-validator-up/src/bin/solana-test-validator-up.ts packages/solana-test-validator-up/jest.config.js .github/CODEOWNERS teams.json README.md tsconfig.json tsconfig.build.jsonyarn readme-content:checkyarn lint:teamsyarn workspace @metamask/solana-test-validator-up run changelog:validatenode packages/solana-test-validator-up/dist/bin/solana-test-validator-up.mjs --helpNote
Medium Risk
Adds a new CLI that downloads and installs external Solana/Agave binaries into local/global caches and writes executable wrappers, which can impact developer/CI environments if misconfigured or if artifact verification fails.
Overview
Introduces a new package,
@metamask/solana-test-validator-up, which installs a pinned Solana/Agave release (defaultv3.1.14) into the MetaMask cache, verifies SHA-256 checksums, and generatesnode_modules/.binwrappers forsolana-test-validatorandsolanavia thesolana-test-validator-upCLI (includingcache clean).Wires the package into the monorepo (TypeScript project references,
yarn.lock, README package list/graph) and sets ownership metadata inCODEOWNERSandteams.json, alongside adding standard package docs/licenses, Jest config, and installer unit tests.Reviewed by Cursor Bugbot for commit 9b6bf08. Bugbot is set up for automated code reviews on this repo. Configure here.