Skip to content

Commit 4a35bf5

Browse files
authored
Merge pull request #752 from MetaCell/dvcorreia-patch-1
Fix documentation typos
2 parents f14d880 + 776619e commit 4a35bf5

9 files changed

Lines changed: 11 additions & 12 deletions

File tree

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ A JRE is needed to run the code generators based on openapi-generator.
108108

109109
For more info, see [here](https://openapi-generator.tech/docs/installation).
110110

111-
112111
## CloudHarness command line tools
113112
To use the cli tools, install requirements first:
114113

docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Index of the documentation articles
22
- [Create and run a deployment](./build-deploy/README.md)
3-
- [Create a codefresh continuous deployment](./build-deploy/codefresh.md)
3+
- [Create a codefresh continuous deployment](./build-deploy/ci-cd/codefresh.md)
44
- [Configure the Helm chart](./build-deploy/helm-configuration.md)
55
- [Set up environments](./build-deploy/environments.md)
66
- [Work with local deployments](./build-deploy/local-deploy/README.md)

docs/accounts.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ A user account must be provided to access to the MNP secured applications.
1313
To put a gatekeeper in front of your application, set `harness/secured` to `true`
1414
in the application's values.yaml.
1515

16-
To assign paths and roles, set `uri_role_mapping` as you would do in the [gatekeeper configuration file resources](https://github.com/gogatekeeper/gatekeeper/blob/master/docs/content/userguide/_index.md#configuration-options).
16+
To assign paths and roles, set `uri_role_mapping` as you would do in the [gatekeeper configuration file resources](https://github.com/gogatekeeper/gatekeeper/blob/master/docs/content/configuration/_index.md).
17+
1718

1819
Example:
1920

@@ -27,6 +28,7 @@ harness:
2728
- administrator
2829
```
2930
31+
3032
See the [Gogatekeeper official documentation](https://gogatekeeper.github.io/gatekeeper/userguide) for more.
3133
3234

docs/applications/secrets.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## What secrets are
44

5-
Kubernetes Secrets let you store and manage sensitive information, such as passwords, OAuth tokens, and ssh keys. Storing confidential information in a Secret is safer and more flexible than putting it verbatim in a Pod definition or in a container image. See [Secrets design document](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/auth/secrets.md) for more information.
5+
Kubernetes Secrets let you store and manage sensitive information, such as passwords, OAuth tokens, and ssh keys. Storing confidential information in a Secret is safer and more flexible than putting it verbatim in a Pod definition or in a container image. See [Secrets design document](https://github.com/kubernetes/design-proposals-archive/blob/main/auth/secrets.md) for more information.
66

77
**CloudHarness has build-in support for application specific kubernetes secrets.**
88

docs/build-deploy/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ To build and reploy
9494

9595
## Continuous deployment with Codefresh
9696

97-
See [here](./codefresh.md).
97+
See [here](./ci-cd/codefresh.md).
9898

9999
## Relevant files and directory structure
100100
Deployment files are automatically generated with the script

docs/build-deploy/environments.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ respect to the production build.
66

77
## How to set the environment
88

9-
The environment of the current deployment can ve set with the parameter `--env` (`-e`)
9+
The environment of the current deployment can be set with the parameter `--env` (`-e`)
1010
of `harness-deployment`.
1111

1212
When the environment is set, specific environment configuration files are included, potentially overriding any value in the system.

docs/dev.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ The skaffold configuration is generated by the `create_skaffold_configuration(..
232232
This function also generates the skaffold entries for the Dockerfiles of the micro-services used in the application.
233233
The skaffold generation is based on the [`skaffold-template.yaml`](../deployment-configuration/skaffold-template.yaml) from the CloudHarness project located in [`deployment-configuration`](../deployment-configuration/).
234234
This base configuration is merged with the configuration dedicated to a specific project and which is located in the `deployment-configuration` folder of the project.
235-
Finally, once all the requiered information are injected in the skaffold configuration dictionnary, the dictionnary is saved as a YAML file in the `deployment/skaffold.yaml` file in the project directory.
235+
Finally, once all the requiered information is injected in the skaffold configuration dictionnary, the dictionnary is saved as a YAML file in the `deployment/skaffold.yaml` file in the project directory.
236236

237237
#### How to extend the deployment generation
238238

docs/jupyterhub.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def change_pod_manifest(self: KubeSpawner):
138138
```
139139

140140
The hook function should be part of a library installable as a pip package.
141-
To see a real example, refer to the main [hook implementation](../applications/jupyterhub/src/harness_jupyter/jupyterhub.py).
141+
To see a real example, refer to the main [hook implementation](../applications/jupyterhub/src/harness_jupyter/harness_jupyter/jupyterhub.py).
142142

143143
### Add the hook
144144

@@ -178,5 +178,3 @@ to the [values.yaml](../applications/jupyterhub/deploy/values.yaml) file.
178178
Cloudharness JupyterHub is integrated with the accounts service so enabling a shared single-sign-on with other applications in the solution.
179179

180180
The spawner is also adapted providing a hook to allow other applications to be based on the hub spawner to run with their own configurations.
181-
182-
Available

docs/tutorials/simple-date-clock-application.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Before installing everything, please be sure you have the following tools instal
3636
== Install {ch} (if it is not yet done)
3737

3838
{ch} is coded in Python, consequently, it's always better to create a local virtualenv dedicated to the project to avoid messing with your system dependencies.
39-
As shown in the snippet above, we will clone the repository, change directory inside the freshly clone directory and create a virtualenv inside (for this tutorial, the Python's version used is CPython 3.10.6).
39+
As shown in the snippet below, we will clone the repository, change directory inside the freshly clone directory and create a virtualenv inside (for this tutorial, the Python's version used is CPython 3.10.6).
4040

4141
First step is to clone the link:{repo_url}[{ch} repository] on your system.
4242

@@ -398,7 +398,7 @@ This will add a new `datetime_controller.py` in the `backend/clockdate/controlle
398398

399399
[IMPORTANT]
400400
You need to notice that all the controllers files (and all the files) are overridden in the `backend` directory.
401-
To prevent files of being overridden, you need to edit the `.openapi-generator-ignore` file, that acts like a `.gitignore` file (in a way), by marking the files/directories that needs to be ignored by the generation.
401+
To prevent files from being overridden, you need to edit the `.openapi-generator-ignore` file, in Cloud Harness template directory, which acts like a `.gitignore` file (in a way), by marking the files/directories that needs to be ignored by the generation.
402402

403403
When we open this file, we get the following controller method:
404404

0 commit comments

Comments
 (0)